only send "Back to normal" if "Notify Back To Normal" is enabled #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
@SuperTux88 Please fix merge conflict(s). |
SuperTux88
force-pushed
the
notify-success-for-back-to-normal
branch
from
8733a3c to
db4738c
Compare
|
done |
|
Please rebase this on the latest master. |
|
Actually, the change is simple enough I'll try to resolve the conflict as part of a merge. |
|
There were no conflicts to resolve. I successfully tested this behavior and merge it. Thanks! |
|
Darn it wouldn't let me push a manually tested change. $ git push origin master
Counting objects: 18, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (18/18), 1.48 KiB | 0 bytes/s, done.
Total 18 (delta 6), reused 0 (delta 0)
remote: Resolving deltas: 100% (6/6), completed with 6 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "Jenkins" is expected.
To git@github.com:jenkinsci/slack-plugin.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:jenkinsci/slack-plugin.git'Please rebase on the latest master. |
send a "Success" even if the previous build failed, if only "Notify Success" is enabled but "Notify Back To Normal" is disabled.
SuperTux88
force-pushed
the
notify-success-for-back-to-normal
branch
from
db4738c to
caeb8c2
Compare
Done :) |
|
Thanks :) |
|
Feel free to subscribe to #296 for updates related to Slack Plugin 2.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send a "Success" even if the previous build failed, if only "Notify
Success" is enabled but "Notify Back To Normal" is disabled.
I need this because I have a job to build pull requests. Then a "Back to normal" is weird because the successful build can be from another PR than the previous broken build. The failing PR is still failing.